Pay-Table analyzer programming question.

Quote: tringlomane

My guess is you have a tiny evaluation error somewhere, which may be difficult to find. :( 976/9/6 JoB should be exactly 100%.

Quote: ChrisE

That's exactly what I was worried about. With such a tiny issue it's going to be really difficult to find. Thanks for your time, though.

Quote: ChrisE

Sadly, the results are even further off

Quote: CrystalMath

for (int k = 0; k < 5; k++)
   for (int l = k + 1; l < 5; l++)
      for (int m = l + 1; m < 5; m++)
         for (int n = m + 1; n < 5; n++)
            fourHold5[HandIndex4(conHand[k], conHand
, conHand[m], conHand[n])]
++;

I doubt this is the problem, but if I were doing this, I think I would do:

for(int k = 0; k < 1; k++)
   for(int l = k + 1; l < 2; l++)
      for(int m = l + 1; m < 3; m++)
         for(int n = m + 1; n < 4; n++)
...

for (int c5 = 4; c5 < 52; c5++) {
for (int c4 = 3; c4 < c5; c4++) {
for (int c3 = 2; c3 < c4; c3++) {
for (int c2 = 1; c2 < c3; c2++) {
for (int c1 = 0; c1 < c2; c1++) {

    ...

} } } } }

Quote: JB

Quote: CrystalMath

for (int k = 0; k < 5; k++)
   for (int l = k + 1; l < 5; l++)
      for (int m = l + 1; m < 5; m++)
         for (int n = m + 1; n < 5; n++)
            fourHold5[HandIndex4(conHand[k], conHand
, conHand[m], conHand[n])]
++;

I doubt this is the problem, but if I were doing this, I think I would do:

for(int k = 0; k < 1; k++)
   for(int l = k + 1; l < 2; l++)
      for(int m = l + 1; m < 3; m++)
         for(int n = m + 1; n < 4; n++)
...

The more elegant approach (in my opinion) is to reverse the order and do this:

for (int c5 = 4; c5 < 52; c5++) {
for (int c4 = 3; c4 < c5; c4++) {
for (int c3 = 2; c3 < c4; c3++) {
for (int c2 = 1; c2 < c3; c2++) {
for (int c1 = 0; c1 < c2; c1++) {

    ...

} } } } }

This is the approach used in the Wizard's video poker calculator.

Quote: CrystalMath

Can you explain what convert_hand is supposed to do? To me, it looks like the results would always be 0.

Quote: ChrisE

Haha, that's true, but not what I meant! I mean I'm going to leave out the feature of letting you find the expected return for a paytable as a whole... and instead just have a single hand analyzer and "best play" trainer.

Quote: teliot

I can run the whole cycle for a pay table in about 2 seconds. You are doing something inefficient. Mike has written at length about how to write efficient VP analyzer code, you should read that.

Quote: ChrisE

Yes, I've read it, and the VPGenius article he mentions and there's just some things that I'm missing. I was trying to get it working, then optimize it... but since it's not working I'm going to move on and come back to it later.

Quote: teliot

You don't need to optimize anything. It runs fast. Even poorly written code will execute a full cycle in under 5 seconds. I do not use nested for loops. I use one for loop that runs from 1 to 134459.

Quote: ChrisE

I'm fairly certain my problem is somewhere in populating the arrays before you even get to the 134459 hands portion... but I really don't know.

Quote: RicardoEsteban

[ ] skilled programmer giving programming advice ITT

[ x ] failed AP giving programming advice ITT

Quote: Mission146

Quote: RicardoEsteban

[ ] skilled programmer giving programming advice ITT

[ x ] failed AP giving programming advice ITT

It's clear that you have no purpose here other than to follow Teliot around and attempt to insult him. Were I so obsessed with a person, I'd probably send flowers, or something.

NUKED-Trolling, Personal Insult

Quote: ChrisE

For anyone interested here's what I have so far on my game.

https://dl.dropboxusercontent.com/u/22699631/PokerEV/PokerEV.html

It still has a long way to go, but it will show the best play, plus if you push the Best Play button you'll get a list of all the EVs. They seem to check out with vpgenius so I think I've got that going correctly.